search

tus / tus-py-client

A Python client for the tus resumable upload protocol
https://tus.io/
MIT License
169 stars 45 forks source link

Client Certificate #84

Open quality-leftovers opened 1 year ago

quality-leftovers commented 1 year ago

Would it be possible to expose the cert options of the requests calls so the client can be used with tus instance is running behind a reverse proxy requiring client certificate based authentication?

See: https://requests.readthedocs.io/en/latest/user/advanced/#client-side-certificates.

Acconut commented 1 year ago

Sure, would you be interested in opening a PR for this?

quality-leftovers commented 1 year ago

Aye. Might need some guidance since I'm not a python guy, though.

I'll submit a PR in a bit.

quality-leftovers commented 1 year ago

See PR above.

Just one question: I've noticed that I cannot run the CI job in my fork. Maybe you enable workflow_dispatch as trigger in the CI.yml in the future to enable making it easier to run the pipeline in a fork.

Acconut commented 1 year ago

I am not entirely sure what you mean here. In PR, the CI will only run after we allow it do run, which I just did. In a fork, you should be able to enable actions on your own AFAIK.

quality-leftovers commented 1 year ago

Nevermind, I'm stupid. I activated the github actions only after my push and was unable to manually run the action because it only triggers on commit so I got confused.