Closed nhairs closed 9 months ago
@Acconut - I should add,
a. it /might/ be better now that we know cause of the broken Windows tests that we scrap this particular PR because there's a lot of potentially breaking changes (due to specifying / narrowing types for instance) and instead we could do a bunch of smaller changes
b. If we're making breaking changes - do we lean into it and start a 2.0.0.dev
branch for other changes we may want before releasing it?
I haven't look thoroughly at this PR yet because it's a lot of changes, but I can answer the two recent questions.
it /might/ be better now that we know cause of the broken Windows tests that we scrap this particular PR because there's a lot of potentially breaking changes (due to specifying / narrowing types for instance) and instead we could do a bunch of smaller changes
I agree. It would make sense to fix the Windows tests in a separate PR and see how many of the improvements we can pursue in individual PRs before breaking backwards compatibility. All the other changes can then be done afterwards for a v2.
If we're making breaking changes - do we lean into it and start a
2.0.0.dev
branch for other changes we may want before releasing it?
Yes, breaking changes will require a v2 release as we follow SemVer for all of our software :) If there are additional breaking changes, now will be a good time to make them. However, I don't know any changes out of my head that we had planned.
In that case, probably don't worry about reviewing this PR, I'll break it up into a few (or more).
May not be for a little while though - depends on what I'm working on.
Thank you very much for your help, @nhairs! I cherry picked the test fixes in https://github.com/tus/tus-py-client/pull/91, so we now have green CI in main again.
Fixes #56, #49.
In addition to moving to
pyproject.toml
format, I've made a few other fairly significant updates:CONTRIBUTORS
from the git history, removed theAUTHORS
file, and updatedLICENSE
to reference the contributors file since under the MIT Licence each contributor still maintains copyright over the code they added.README.md
.grip
tox.ini
, updatedpython-requires>=3.8
, added 3.12 to CI"x".format(...)
)Fingerprint.get_fingerprint
- now only acceptsBinaryIO
.StringIO
files.Test Plan
pyproject.toml
againstvalidate-pyproject
README.md
usinggrip
Questions / Discussion / Misc
Note
I strongly recommend this is merged using a squash commit (opposed to a merge or rebase - the commit history here is pretty garbage).