tus / tus-resumable-upload-protocol

Open Protocol for Resumable File Uploads
https://tus.io
MIT License
1.48k stars 103 forks source link

Cache-Control: no-store only while upload is incomplete #106

Closed ronag closed 7 years ago

ronag commented 7 years ago

Once upload is complete caching should be allowed.

Acconut commented 7 years ago

Please be aware that the specification does only required the Cache-Control: no-store header for HEAD responses as the GET request/response is not defined by the protocol. Even after an upload is finished, the HEAD response should not be cached as certain properties of the upload still may change, e.g. its expiration date or it may become totally unavailable. Therefore, I think, the HEAD response should not be cached.

ronag commented 7 years ago

as certain properties of the upload still may change

That is true. However, I think this should be a SHOULD and not a MUST once the upload has completed. The server might be able guarantee that it will not change if e.g. there is no expiration date.

Acconut commented 7 years ago

Agreed, closing in favor of #121.