tus / tus-resumable-upload-protocol

Open Protocol for Resumable File Uploads
https://tus.io
MIT License
1.49k stars 102 forks source link

Why is checksum required for multiple small PATCH uploads? #108

Closed ronag closed 7 years ago

Acconut commented 7 years ago

Checksums are never required. They are an optional extension and may be used if the client desires to do. Therefore, I can't follow your question. Would you mind explaining your concerns?

ronag commented 7 years ago

but MAY also use multiple small requests successively for scenarios where this is desirable, for example, if the Checksum extension is used.

This is confusing me a bit. It sounds like the checksum extension should be used for these scenarios.

Acconut commented 7 years ago

This is confusing me a bit. It sounds like the checksum extension should be used for these scenarios.

The Checksum extension is one example for why one would choose to break the entire upload into multiple smaller requests instead of one single PATCH request as we usually recommend. This means that checksums are never required even if you use small requests.

ronag commented 7 years ago

@Acconut: Thanks! Might want to change the wording a little bit?

Acconut commented 7 years ago

Frankly, for me this sentence is quite clear, probably because I wrote it :) Would have any suggestions on what to improve there?

ronag commented 7 years ago
but MAY also use multiple small requests successively. This could be useful for scenarios where for example the Checksum extension is used.

Now that I know what you mean it is quite clear to me as well. Maybe just separate the sentence so that one does not directly associate small requests with checksums.