search

tus / tus-resumable-upload-protocol

Open Protocol for Resumable File Uploads
https://tus.io
MIT License
1.49k stars 102 forks source link

remove misleading line #97

Closed ifedapoolarewaju closed 8 years ago

ifedapoolarewaju commented 8 years ago

I found this line confusing.

Since the spec says The Client SHOULD NOT include the Tus-Resumable header in the request and the Server MUST ignore the header. I thought it'd make sense to rather remove that line from the example so it doesn't mislead anyone else as it did me. Please let me know if there's anything out of place. :)

Question though: Does it mean the header Tus-Resumable should also be excluded from the response, since the server is expected to ignore it?

Acconut commented 8 years ago

Thank you for this.

Does it mean the header Tus-Resumable should also be excluded from the response, since the server is expected to ignore it?

No, it doesn't :)

ifedapoolarewaju commented 8 years ago

@Acconut Do I get Collaborator's credit for this? 😉

Acconut commented 8 years ago

@ifedapoolarewaju Sure, let me add you :)

Acconut commented 8 years ago

Here you go: 9228fb16e4e338488ad1062e460b938ae1eee2d8 If you want any information there to be changed, feel free to contact me.

ifedapoolarewaju commented 8 years ago

It’s perfect thank you! :)

On 11 Oct 2016, at 2:24 PM, Marius notifications@github.com wrote:

Here you go: 9228fb1 https://github.com/tus/tus-resumable-upload-protocol/commit/9228fb16e4e338488ad1062e460b938ae1eee2d8 If you want any information there to be changed, feel free to contact me.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tus/tus-resumable-upload-protocol/pull/97#issuecomment-252915119, or mute the thread https://github.com/notifications/unsubscribe-auth/AH_tJee23cswLZxpyDS2kqpKDPSwKy-Wks5qy439gaJpZM4KC62Y.