search

tus / tusd

Reference server implementation in Go of tus: the open protocol for resumable file uploads
https://tus.github.io/tusd
MIT License
3.05k stars 475 forks source link

s3store fix incomplete part keys #1042

Closed butonic closed 8 months ago

butonic commented 10 months ago

When using a different prefix for metadata files uploads break because the code sometimes uses metadataKeyWithPrefix when it should use keyWithPrefix.

Unless I understood something completely wrong and failed to understand what the debug session was trying to tell me ;-)

Acconut commented 10 months ago

Thank you for this PR, but I am not too sure about this change. The documentation clearly states that the metadata prefix will be used for the .part object: https://github.com/tus/tusd/blob/c856f723619a0a388c619d68357b9510c8632640/pkg/s3store/s3store.go#L107-L113

IIRC, the idea is that the object prefix defines the prefix for the completed file uploads. All additional objects (e.g. .info and .part) will be put under the metadata prefix.

Acconut commented 8 months ago

Closing this issue due to inactivity. Feel free to leave a comment if you want to continue the discussion :)