Breacking change on Hook-Name header

tus / tusd

Reference server implementation in Go of tus: the open protocol for resumable file uploads

https://tus.github.io/tusd

MIT License

2.93k stars 465 forks source link

Breacking change on Hook-Name header #1061

Closed mosi-kha closed 5 months ago

mosi-kha commented 5 months ago

Describe the bug in tusd v1, we had Hook-Name header to determine hook but in tusd v2 this header removed and set to payload with Type so in states we have problem to parse body.

To Reproduce Run tusd v2

Expected behavior In addition to being in body, it should be in the header as well

Setup details

Operating System: Linux
Used tusd version: v2
Used tusd data storage: S3
Used tus client library: tus-py-client

Acconut commented 5 months ago

tusd v2 included breaking changes as explained in the release notes and the accompanying blog post: https://github.com/tus/tusd/releases/tag/v2.0.0. The new version includes a reworked hook interface, so you need to adapt to the new interface if you upgrade tusd.

mosi-kha commented 5 months ago

@Acconut Thanks for the response, It would be better if it remained in the header