search

tus / tusd

Reference server implementation in Go of tus: the open protocol for resumable file uploads
https://tus.github.io/tusd
MIT License
3.04k stars 475 forks source link

Simultaneous support for -01 and -02 of IETF draft #1066

Closed Nealsoni00 closed 7 months ago

Nealsoni00 commented 8 months ago

This improves commit 09f105d53afff61249bb781794615e1e909e2125 to support both draft v01 and draft v02 versions of the ietf upload protocol

Addresses https://github.com/tus/tusd/issues/1065

This is important as iOS 17.2 supports only draft v01 which means that draft is here to stay

Nealsoni00 commented 8 months ago

Appreciate the review, will work to resolve all comments soon!

Acconut commented 8 months ago

Let me know once this is ready for another review.

Nealsoni00 commented 8 months ago

Hey @Acconut it is now ready! lmk if you don't like the style i used to dedulicate the test logic. The goal was to find what was repeated (and made sense to consolidate) and make for _, test := range experimentalUploadTests { to run the tests with the same setup code just different input and output.

Nealsoni00 commented 7 months ago

Hey — appreciate you looking into this and getting it merged!