search

tus / tusd

Reference server implementation in Go of tus: the open protocol for resumable file uploads
https://tus.github.io/tusd
MIT License
3.04k stars 475 forks source link

S3 Storage GetReader Range Support #1073

Closed pcfreak30 closed 8 months ago

pcfreak30 commented 8 months ago

Is your feature request related to a problem? Please describe. I needed the ability to pass the range (partial content) to the s3 options in GetReader

Describe the solution you'd like I have created it https://github.com/LumeWeb/tusd/commit/3615bc502881400d4671bdfe893065a7e03f2c76

Describe alternatives you've considered N/A

Can you provide help with implementing this feature? See https://github.com/LumeWeb/tusd/commit/3615bc502881400d4671bdfe893065a7e03f2c76

Additional context I have not made a PR as I want feedback/discussion and potentially have the team implement it in their own way if they feel they need to.

Acconut commented 8 months ago

There has been a discussion in https://github.com/tus/tusd/pull/1048 about adding support for ranged GET requests. The result was that we first need to find a good API design for this, which suits all storage implementations. Using context, like you did, is possible but not my preferred option because context values should not be used to implement optional parameters. I would rather have storages implement an explicit method for retrieving content with ranges.

I am going to close this issue in favor of https://github.com/tus/tusd/issues/1064. Feel free to comment over there and let us know what you think.