tusdotnet / tusdotnet

.NET server implementation of the Tus protocol for resumable file uploads. Read more at https://tus.io
MIT License
663 stars 70 forks source link

Make it easier to run tusdotnet on ASP.NET Core on .NET Framework #38

Closed smatsson closed 6 years ago

smatsson commented 6 years ago

Side note: Microsoft suck at naming stuff :)

tusdotnet runs just fine on ASP.NET Core on both .NET Framework and .NET Core (the actual runtimes). The problem is that since we use build targets to expose the correct middleware (as there is no other viable way of knowing what pipeline we run) users who run ASP.NET Core on .NET Framework need to setup an extra OWIN pipeline to be able to run tusdotnet. This is bad in terms of performance while also introducing a high threshold to run tusdotnet.

Read more: https://github.com/tusdotnet/tusdotnet/wiki/Troubleshoot:-"'IApplicationBuilder'-does-not-contain-a-definition-for-'UseTus'"-in-ASP.NET-Core

We should expose the ASP.NET Core middleware even if the build target is net452. Pros:

Cons:

smatsson commented 6 years ago

Fixed and includes new sites for testing Owin on .NET Framework, ASP.NET Core 1.1 on .NET Core and ASP.NET Core 2.0 on .NET Framework