tusen-ai / SimpleTrack

MIT License
333 stars 63 forks source link

threshold_high is never used in NMS? #12

Closed xinshuoweng closed 2 years ago

xinshuoweng commented 2 years ago

Hi Ziqi,

I have one simple question regarding the NMS. Because the threshold_high is set to 1.0, it seems that the block of code below is never used in NMS: https://github.com/TuSimple/SimpleTrack/blob/3b44d6d197b06501f01b939e2f1da764e44ac5dd/mot_3d/preprocessing/nms.py#L47-L71 Could you please illustrate a bit more how and where the above code is useful?

Thanks!

ziqipang commented 2 years ago

@xinshuoweng Thanks for the interest, your ab3dmot work innovates SimpleTrack a lot. Short answer: yes, we haven't used it. A more-informative answer: Our NMS code is actually adapted from the code for weighted-NMS, which uses the bounding boxes with IOU>threshold_high to vote a better bounding box, and that is what this segment of code is for. But in SimpleTrack, we by default use the normal NMS instead of weighted-nms, so we set threshold_high=1.0 to for this.

Lzc6996 commented 2 years ago

@xinshuoweng About the weighted-NMS, you can refer the Bounding box voting in Object detection via a multi-region & semantic segmentation-aware CNN model

ziqipang commented 2 years ago

Close due to no action.