search

tushar5526 / sarthi

Vercel for Backend! Easily setup preview environments with just Docker 🐳
MIT License
11 stars 7 forks source link

Add support to allow ports as variables in docker compose #46

Open tushar5526 opened 6 months ago

tushar5526 commented 6 months ago

For a project's docker-compose as specified. 

services:
  app: 
     image: ..
     ports:
        - ${PORT:-3000}:3000

compose file should be converted to a processed compose file using docker-compose config after loading the environment variables from Vault and then it should be processed further.

Amandeepsingh25 commented 5 months ago

I'm eager to contribute and resolve the Docker Compose port variable issue.I would like to contribute to sarthi.Please assign me this issue @tushar5526

GJS2162 commented 5 months ago

Hi Tushar,

I would like to take on this task of adding support to allow ports as variables in the Docker Compose file (#46). I have experience working with Docker and Docker Compose, and I believe I can implement this feature efficiently.

Please assign this task to me.

Thank you!

Best regards, Gaurav Ji Srivastava

Amandeepsingh25 commented 5 months ago

53

tushar5526 commented 5 months ago

Hey @Amandeepsingh25 @GJS2162 great first try but I think there was a miss on my end to explain the problem statements in a better way.

First of all I wanted to know were your folks able to setup the project locally ?

Amandeepsingh25 commented 5 months ago

@tushar5526 yes I have run the docker compose file locally but fail to unerstand the endpoint for knowing the output .

tushar5526 commented 5 months ago

@Amandeepsingh25 check out the contributor's guide in the readme.

GJS2162 commented 5 months ago

Hey @Amandeepsingh25 @GJS2162 great first try but I think there was a miss on my end to explain the problem statements in a better way.

First of all I wanted to know were your folks able to setup the project locally ?

Sorry for the late reply.

Initially, I reviewed the documentation to understand how to run the project. However, I decided to proceed directly with the task at hand. I will give it a try, and if I encounter any issues or need assistance, I will reach out for help.

Thank you!