search

tusharmath / node-config-ts

A simple node configuration manager
61 stars 31 forks source link

Use environment variable USERNAME instead of USER on Windows OS #42

Closed ivosh closed 5 years ago

ivosh commented 5 years ago

Windows OS uses USERNAME environment variable to convey the same meaning as USER on UNIXes.

However node-config-ts currently tries to locate user-specific config only based on USER. This suits Linux, *BSD and Solaris users, but not Windows ones.

I'd like propose to check also USERNAME environment variable if USER is not set.

ivosh commented 5 years ago

Will prepare a PR shortly.

ivosh commented 5 years ago

Thank you for merging PR #43. Could we expect a release any soon?

tusharmath commented 5 years ago

Weird it’s supposed to be auto published. I’ll check

Tushar Mathur tusharmath.com ( https://tusharmath.com )

On Fri, Nov 8 2019 at 11:34 AM, < notifications@github.com > wrote:

Thank you for merging PR #43 ( https://github.com/tusharmath/node-config-ts/pull/43 ). Could we expect a release any soon?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/tusharmath/node-config-ts/issues/42?email_source=notifications&email_token=AABPPMV7WV3AW2MCA3X3ZRDQST6QPA5CNFSM4JKEPCX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDO2S5A#issuecomment-551397748 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AABPPMXI5QKQG6FNKV7JECLQST6QPANCNFSM4JKEPCXQ ).

tusharmath commented 5 years ago

:tada: This issue has been resolved in version 2.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: