tusharmath / observable-air

Observable for the calorie conscious
MIT License
34 stars 3 forks source link

fix(fromArray): use setImmediate() instead of setTimeout() #64

Closed tusharmath closed 7 years ago

tusharmath commented 7 years ago

observable-air@ benchmark /home/travis/build/tusharmath/observable-air node .dist/benchmarks/run

Node: v7.1.0 V8: 5.4.500.36

┌────────────────────────┬────────────────────┬─────────┐
│ name                   │ ops/sec            │ samples │
├────────────────────────┼────────────────────┼─────────┤
│ file -> map -> reduce  │ 167 (±2.3%)        │ 61      │
├────────────────────────┼────────────────────┼─────────┤
│ file -> takeN(0, n/10) │ 866 (±2.36%)       │ 72      │
├────────────────────────┼────────────────────┼─────────┤
│ file -> scan -> reduce │ 34 (±1.73%)        │ 74      │
├────────────────────────┼────────────────────┼─────────┤
│ tryCatch               │ 7,115,785 (±3.22%) │ 63      │
├────────────────────────┼────────────────────┼─────────┤
│ scheduleImmediately    │ 172,970 (±2.6%)    │ 60      │
└────────────────────────┴────────────────────┴─────────┘
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 91.538% when pulling 5264552f61bdc918558c46bd1bb17a1a756ceb2b on fromArray into 264e04584b13f743a6003214a399f668ebee3057 on master.

tusharmath commented 7 years ago

observable-air@ benchmark /home/travis/build/tusharmath/observable-air node .dist/benchmarks/run

Node: v7.2.0 V8: 5.4.500.43

┌────────────────────────┬─────────────────────┬─────────┐
│ name                   │ ops/sec             │ samples │
├────────────────────────┼─────────────────────┼─────────┤
│ file -> map -> reduce  │ 290 (±2.37%)        │ 80      │
├────────────────────────┼─────────────────────┼─────────┤
│ file -> takeN(0, n/10) │ 1,799 (±2.26%)      │ 84      │
├────────────────────────┼─────────────────────┼─────────┤
│ file -> scan -> reduce │ 61 (±1.79%)         │ 71      │
├────────────────────────┼─────────────────────┼─────────┤
│ tryCatch               │ 14,127,346 (±1.82%) │ 83      │
├────────────────────────┼─────────────────────┼─────────┤
│ scheduleImmediately    │ 355,967 (±3.26%)    │ 79      │
└────────────────────────┴─────────────────────┴─────────┘
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 91.538% when pulling 936fa3246adb0b23c17135f1e14b549d4e23bbd5 on fromArray into 19ffa916ee903f1088cb990abf7dee6fe1f0917d on master.

tusharmath commented 7 years ago

create a new Scheduler — requestAsap