search

tusharmath / observable-air

Observable for the calorie conscious
MIT License
34 stars 3 forks source link

fix(sample): fix sample missing the first value #74

Closed tusharmath closed 7 years ago

tusharmath commented 7 years ago

sample$ subscription should happen post the sources are subscribed to

tusharmath commented 7 years ago

observable-air@ benchmark /home/travis/build/tusharmath/observable-air node .dist/benchmarks/run

Node: v7.2.0 V8: 5.4.500.43

┌────────────────────────┬────────────────────┬─────────┐
│ name                   │ ops/sec            │ samples │
├────────────────────────┼────────────────────┼─────────┤
│ file -> map -> reduce  │ 222 (±0.74%)       │ 82      │
├────────────────────────┼────────────────────┼─────────┤
│ file -> takeN(0, n/10) │ 553 (±1.15%)       │ 84      │
├────────────────────────┼────────────────────┼─────────┤
│ file -> scan -> reduce │ 56 (±1.72%)        │ 83      │
├────────────────────────┼────────────────────┼─────────┤
│ tryCatch               │ 13,965,462 (±0.7%) │ 88      │
├────────────────────────┼────────────────────┼─────────┤
│ scheduleImmediately    │ 390,255 (±0.87%)   │ 82      │
└────────────────────────┴────────────────────┴─────────┘
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 91.612% when pulling d5fa71b7c2ef5fee594b10906d01643ea3bee528 on sample-fixup into 05d830b0832d0dc443571201109455dcc5494647 on master.