tushartushar / DesigniteJava

Detects smells and computes metrics of Java code
https://www.designite-tools.com/products-dj
Apache License 2.0
171 stars 62 forks source link

Recursive inheritance depth analysis causes StackOverflows in large projects #52

Open AntonisGkortzis opened 6 years ago

AntonisGkortzis commented 6 years ago

Temporarily patched with Exception handling.

luiscruz commented 5 years ago

I think this is related:

When I run Designite over the Android project SteamGifts I get weird overflow messages:

This sentenced get repeated several times in the output.

Notes:

wnoizumi commented 5 years ago

Hi, I'm facing the same problem when analyzing large projects such as Elasticsearch (v1.2.2). Is there any workaround for this problem?

Thodoras commented 5 years ago

Hi,

The work around of course is to exchange recursion with a more itterative approach. As far as I remember I used recursion in graph class where a DFS is used. The workaround is to use a stack (data structure) to keep track on what the algorithm has explored.

I don't think it is too troublesome to tweek the code, once the DFS functionality is found.


T.Stassinopoulos

On Fri, Apr 5, 2019 at 9:04 PM Willian Nalepa Oizumi < notifications@github.com> wrote:

Hi, I'm facing the same problem when analyzing large projects such as Elasticsearch (v1.2.2). Is there any workaround for this problem?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tushartushar/DesigniteJava/issues/52#issuecomment-480369846, or mute the thread https://github.com/notifications/unsubscribe-auth/AKvKoNf5Ej0GxsyYtlaXApYxV7z_BlAEks5vd5AogaJpZM4U3qCk .