tusmanakhter / MigrantHub

MIT License
4 stars 3 forks source link

Profile + Infinite Scroller #239

Closed tusmanakhter closed 5 years ago

tusmanakhter commented 5 years ago

This pr is for #238 and #204.

tusmanakhter commented 5 years ago
  • The profile page link is broken (can't view Migrant Profile).

View was completely removed. Top link will now bring you to edit profile. Not sure why we even have the same link in two places.

  • The app crashes when you go on My Events from any other page aside from events due to a nested update of the components.

Fixed

tusmanakhter commented 5 years ago

If we're no longer supporting friends. Then removing the view profile is fine. However, if we plan to bring back friends eventually. Then view profile will be needed for that feature.

Don't think we will be bringing it back in the scope of this project. Even if we do bring it back it will display way less information than what we were showing before due to privacy.

  • Mother tongue field is displayed as languages. If our intention is to know the mother tongue of the users then it would be better to label it as such. Otherwise, the user may order the languages in any order.

Added label for mother tongue.

  • The Proficiency exams and other section is getting saved to the db, but the value itself is not being displayed when I reload the page. Also, it would be nice if other was labeled with a bit more detail. i.e. what is the user supposed to enter. Other exams? degrees? Any of of these two.

Fixed minor display issue. As for other, its next to the proficiency exams, hopefully user understands.

  • Business edit profile allows the user to delete some fields that are required in signup

Added call to server validation for business profile.

  • Not sure if this falls out of the scope / was accidentally removed. (Didn't test this issue on master) All the integer fields other than the user's age has no validation and is allowing negative integer values.

There was no validation added to client. Added client validation and properly called server validation on request.

iamlax commented 5 years ago

If we're no longer supporting friends. Then removing the view profile is fine. However, if we plan to bring back friends eventually. Then view profile will be needed for that feature.

Don't think we will be bringing it back in the scope of this project. Even if we do bring it back it will display way less information than what we were showing before due to privacy.

  • Mother tongue field is displayed as languages. If our intention is to know the mother tongue of the users then it would be better to label it as such. Otherwise, the user may order the languages in any order.

Added label for mother tongue.

  • The Proficiency exams and other section is getting saved to the db, but the value itself is not being displayed when I reload the page. Also, it would be nice if other was labeled with a bit more detail. i.e. what is the user supposed to enter. Other exams? degrees? Any of of these two.

Fixed minor display issue. As for other, its next to the proficiency exams, hopefully user understands.

  • Business edit profile allows the user to delete some fields that are required in signup

Added call to server validation for business profile.

  • Not sure if this falls out of the scope / was accidentally removed. (Didn't test this issue on master) All the integer fields other than the user's age has no validation and is allowing negative integer values.

There was no validation added to client. Added client validation and properly called server validation on request.

Nice, everything looks good now. There is validation for all the ages, fields are clearer, required fields are required.

Should we allow negatives for these two fields?

image