tusury / vt-middleware

Automatically exported from code.google.com/p/vt-middleware
0 stars 0 forks source link

ldaptive: Method org.ldaptive.auth.AggregateDnResolver.resolve() consistently stalls #225

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Using AggregateDnResolver with any number of DnResolvers defined.
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
1.0.4

Please provide any additional information below.
This issue is caused by there being a redundant call to 
java.util.concurrent.CompletionService.take() on line 163, the first call being 
on line 161.

According to the java.util documentation, each call to the take() method 
"Retrieves and removes the Future ...".  The CompletionService is loaded with 
as many Futures as there are DnResolvers defined (line 144) and both of these 
calls to take() are executed once for each defined DnResolver (line 159).  This 
results in the CompletionService's completionQueue emptying prematurely causing 
the overall execution to stall at either lines 161 or 163.

I would recommend replacing the second call to the take() method on line 163 
with the stored dn value from line 161.

Original issue reported on code.google.com by gho...@gmail.com on 20 Aug 2014 at 10:11

GoogleCodeExporter commented 8 years ago

Original comment by dfis...@gmail.com on 21 Aug 2014 at 1:08

GoogleCodeExporter commented 8 years ago
Fixed in r3042.

Original comment by dfis...@gmail.com on 21 Aug 2014 at 2:48