tutao / tutanota

Tuta is an email service with a strong focus on security and privacy that lets you encrypt emails, contacts and calendar entries on all your devices.

https://tuta.com

GNU General Public License v3.0

6.06k stars 523 forks source link

Use LoginForm, SignupForm and CredentialsSelector in the LoginView/UpgradeSubscriptionWizard #2485

Closed johnbotris closed 3 years ago

johnbotris commented 3 years ago

These GUI elements were extracted into their own classes to be used elsewhere (for gift cards). The code is currently duplicated so we should consolidate

johnbotris commented 3 years ago

regression testing

[x] logging in with new unsaved credentials
[x] saving credentials
[x] logging in with saved credentials
[x] deleting credentials
[x] browser autofill works and the ui reacts properly
[ ] the signup page still works as normal

charlag commented 3 years ago

It's probably not a regression but: I was signing up and used credit card with successful 3DSecure. Then I came back to step 3 (payment data) and I cannot proceed anymore: Screenshot from 2021-01-07 12-39-51

charlag commented 3 years ago

So we didn't remember that we have already paid

johnbotris commented 3 years ago

These changes shouldn't have had an effect on payments. Does this have anything to do with all the braintree test cards having already been used up on the test system?

edit: ok no I'm getting this error too, before the verification window is even opened. Adding payment details later worked though. It seemed to work when using paypal, except the paypal account is already being used

charlag commented 3 years ago

Seems like the error is unrelated

armhub commented 3 years ago

This error is also currently shown if the user tries too many times with the same credit card. We have the server issue #680 to fix this.