tutao / tutanota

Tuta is an email service with a strong focus on security and privacy that lets you encrypt emails, contacts and calendar entries on all your devices.
https://tuta.com
GNU General Public License v3.0
6.11k stars 526 forks source link

UI component cleanup #2559

Open johnbotris opened 3 years ago

johnbotris commented 3 years ago

We still have lots of old/new component pairs, for example TextField and TextFieldN. We should try to move as many of these duplicates over to just using the new versions.

We also have many components that still used with the pattern:

const component = new MyComponent(a, b, c)

m(component)

We should strive to have all components written like:

m(MyComponent, { a, b, c }

While migrating to typescript (#3746) we will mark calls to m with @ts-ignore as a reminder. This usage of m is not supported by the official mithril TS declarations

Old basic omponents left

Many of them could be removed with settings redo (#47).

johnbotris commented 3 years ago

There are also unused components? I don't think they need to be kept around if we aren't using them:

Maybe more

Edit: this is handled

johnbotris commented 3 years ago

We're leaving this issue open as it is ongoing, refer to #2945 for the most recent cleanup activity that was merged to master