Migrate to TypeScript

[bedhub]

We want to migrate our typesystem from flow to TypeScript.

• [x] oxmsg
• [x] admin client
• [x] web client
• [x] client code generators
• [x] use .ts file extension instead of .js, make sure that git history is preserved

Test notes

• [ ] General
  • [ ] UI react to resizing: switching between 3, 2 and 1 column
  • [ ] Websocket
    • [ ] Connects
    • [ ] Reconnects after offline and replays updates
    • [ ] Shows status as a stripe bar: not connected, reconnected progress, connected (no indicator)
    • [ ] Logging out works
  • [x] Suspension/retry-after
• [ ] Login
  • [x] Can log in using password form, invalid password error is handled
  • [x] Can log in using saved credentials
  • [x] Can delete saved credentials
  • [x] Can recover password or second factor using recovery code
  • [ ] Second factor prompt works
    • [ ] #3789
    • [ ] 2FA
    • [x] with approval from another client
  • [x] Can approve another client for 2FA
• [x] Signup
  • [x] /signup path works
  • [x] Checks checkboxes, password strength, existing account
  • [x] Can go back and forth between steps
  • [ ] link with /signup#subscription=premium&type=private&interval=12 preselects the option and skips the step
  • [ ] Payment works
    • [x] PayPal
    • [x] Credit card
    • [x] On account
    • [ ] Gift card
• [x] Mail
  • [ ] Viewing mails, switching between mails, scrolling, opening details
    • [x] Deleting
    • [ ] Printing
    • [x] marking Read/unread
    • [x] Showing headers
  • [x] Marked as read automatically
  • [ ] Number of displayed attachments is limited (4 on desktop, 2 on mobile)
  • [x] Is possible to download attachments
    • [ ] Web
    • [x] iOS
    • [x] Android
  • [x] External content is blocked, it's possible to always show it for sender and undo it
  • [x] Inline images are loaded automatically
  • [x] Spam/phishing banners are displayed
  • [x] It is possible to report email as phishing/spam
  • [ ] Shortcuts work in mail and mail list, multiselect works
  • [x] It is possible to move emails
  • [x] It is possible to delete emails
  • [ ] It is possible to drag'n'drop emails into folders
  • [x] It is possible to clear spam folder, there's a message about auto clearing folder
  • [x] There is a message about empty mail folder
  • [x] Email counters are downloaded and updated
  • [x] Selected email/folder are remembered when switching between folders/views
  • [x] Sanitizing mail content works
  • [x] Adding spam rule from contact bubble
  • [x] Calendar invite banner in mail viewer
  • [x] Adding folders
  • [x] Renaming folders
  • [x] Deleting folders
  • [x] Editing mails
    • [x] Sanitizing works
    • [x] Detect internal/external recipients
    • [x] Can send internal emails
    • [x] Can send insecure external emails
    • [x] Can send secure external emails
    • [x] Password is stored with contact and loaded next time
    • [x] Plaintext/rich text mode
    • [x] Rich text actions: lists, bold, italic, links, inline image
    • [x] Inline images are carried over from the viewer
    • [x] External images are carried over from the viewer
    • [x] Other attachments are not carried over from the viewer when replying
    • [x] Carried over when forwarding
    • [x] No subject prompt
    • [x] Saving email
    • [x] Sending with attachments
    • [x] Minimizing
    • [ ] Saved
    • [ ] Can be closed
    • [ ] Can be stacked
    • [x] Reply all works
    • [x] Changing sender works
    • [x] Clicking on recipient bubbles works
    • [ ] edit contact
    • [ ] remove
    • [x] to, cc, bcc are used and populated from draft
• [x] Contacts
  • [x] Viewing
    • [x] Names
    • [x] Birth date
    • [x] Email field and button
    • [x] Location field and button
    • [x] Social networks buttons
  • [ ] Export
  • [ ] Import
  • [x] Merging
  • [x] Sorting
  • [x] Editing
    • [x] Names
    • [x] Birthday
    • [x] Social
    • [x] Address
• [ ] Settings
  • [x] Login settings
    • [x] Changing password
    • [x] Viewing/udpating recovery code
    • [x] Viewing/closing sessions
  • [ ] Mail settings
    • [ ] Default sender
    • [ ] Sender name
    • [ ] Signature
    • [ ] Default delivery
    • [ ] Create contacts
    • [ ] Report spam
    • [ ] The MailReportDialog is shown upon moving mail to spam (Always ask): https://github.com/tutao/tutanota/issues/3804
    • [ ] The SnackBar is shown upon moving mail to spam (Always).
    • [ ] Autoresponder
    • [ ] Activating/deactivating aliases
    • [ ] Adding/removing/editing inbox rules
    • [ ] Adding email notification: https://github.com/tutao/tutanota/issues/3802
    • [ ] Removing/deactivating push identifier: https://github.com/tutao/tutanota/issues/3802
  • [x] Appearance settings
    • [x] Language
    • [x] Theme (incl. whitelabel)
    • [x] Time format
    • [x] Week start
  • [ ] Desktop settings
    • [ ] Spelling checking (Win/Lin)
    • [ ] Mailto handler (Lin)
    • [ ] Run in background (Mac)
    • [ ] Run on startup
    • [ ] Default download path
    • [ ] Email export format
    • [ ] Desktop integration (Lin)
    • [ ] Automatic updates
    • [ ] Manual check
  • [ ] User settings
    • [ ] Viewing list
    • [ ] Adding user
    • [ ] Sender name
    • [ ] Password
    • [ ] Storage
    • [ ] Global admin
    • [ ] Local admin ("administered by")
    • [ ] Activate/deactivate
    • [ ] 2FA
    • [ ] Groups
    • [ ] Aliases
  • [ ] Groups settings
    • [ ] List
    • [ ] Adding group
    • [ ] Name
    • [ ] Admin
    • [ ] Activate/deactivate
    • [ ] Members
    • [ ] Administered groups
  • [ ] Global settings
    • [ ] Spam rules
    • [ ] Viewing
    • [ ] Adding
    • [ ] Deleting
    • [ ] Editing
    • [ ] Moving
    • [ ] Rejected list
    • [ ] Email domains:
    • [ ] Adding
      • [ ] DNS check #3803
      • [ ] Alias
    • [ ] Catch all
    • [ ] Delete
    • [ ] Security
    • [ ] Saving IPs
    • [ ] Enforce password update
    • [ ] Audit log is displayed
  • [ ] Whitelabel settings
    • [ ] Adding whitelabel
    • [ ] Removing whitelabel
    • [ ] Custom notification email
    • [ ] Custom colors
    • [ ] Custom logo
    • [ ] Meta tags and links
    • [ ] Verify on whitelabel domain
  • [ ] Contact form settings
    • [ ] Adding contact form
    • [ ] Editing contact form
    • [ ] Sending message via contact form
    • [ ] Replying to message sent via contact form
    • [ ] Viewing reply in the contact form
  • [ ] Subscription settings
    • [ ] Upgrade
    • [ ] Downgrade
    • [ ] Downloading agreement
    • [ ] #3792
    • [ ] Viewing gift cards
    • [ ] Using gift cards
    • [ ] Adding users
    • [ ] Adding storage
    • [ ] Adding aliases
    • [ ] Adding groups
    • [ ] Adding sharing
    • [ ] Adding contact forms
    • [ ] Deleting account
  • [ ] Payment settings
    • [ ] Changing payment method
    • [ ] Changing invoice data
    • [ ] Downloading invoices
  • [ ] Template settings
    • [ ] Adding languages
    • [ ] Viewing list
    • [ ] Using autocomplete for tempaltes
  • [ ] Knowledge base settings
  • [ ] Group invitations
    • [ ] Sending invitations
    • [ ] Viewing them
    • [ ] Accepting them
• [ ] Calendar
  • [x] Month view
  • [x] Day view
  • [ ] Week view
  • [x] Agenda view
  • [x] Switching between dates
  • [x] Loading & Viewing events
    • [x] Single
    • [x] Repeated
    • [x] Long (2 weeks+)
  • [x] Seeing event changes after update
    • [x] Single
    • [x] Repeated
    • [x] Long (2 weeks+)
  • [ ] Import
  • [ ] Export
  • [x] Sharing
  • [x] Adding calendars
  • [x] Changing calendar details
  • [x] Deleting calendars
  • [x] Editing events
    • [x] New
    • [x] Existing
    • [x] Dates
    • [x] Times
    • [x] Repeating
    • [x] Calendars
    • [x] Invites
    • [x] In shared calendar
    • [x] Editing saved invites
    • [x] Changing attendance
• [ ] Nav menu
  • [x] Invite
  • [ ] Upgrade
  • [x] FAQ search
  • [x] Keyboard shortcuts
  • [x] Gift Cards
• [ ] Search
  • [x] Enabling search
  • [ ] Disabling search
  • [x] Searching mail
  • [x] Searching contacts
  • [x] Filtering mail by attributes
  • [x] Expanding search interval
  • [x] Updates after offline are applied
  • [x] Multiselect for mail
  • [x] Multiselect for contacts
  • [ ] quick search
  • [ ] User search

[charlag]

some converters: https://github.com/khan/flow-to-ts https://github.com/bcherny/flow-to-typescript

[charlag]

another point is enums: https://www.typescriptlang.org/docs/handbook/enums.html

I would recommend to use as const objects at first or maybe const enum where necessary because they have the lowest overhead.

[vitoreiji]

Some preliminary client testing revealed the following issues:

• drop down menus are empty in (#3774):
  • mail viewer
  • contact editor
  • Settings > Email
  • calendar event editor
  • autoresponder editor
  • Settings > Appearence (except for language)
  • Add group
  • selecting tutanota domain
  • shared mailbox config
  • creating custom colors: base theme
  • setting alignment (mail editor)
  • folder settings
• no button to (#3775):
  • add 2FA
  • close active sessions
  • add alias
  • add inbox rule
  • add spam rule
  • add custom domain
  • add custom notification emails
  • add gift card
  • download invoice
• 404 when (#3774):
  • changing language
  • viewing recovery code
  • adding language to template
• receiving mail with attachment throws (#3769)
• external mailbox cannot view received emails (#3776)
• contact form user cannot view replies, throws (#3776):

  mithril.js:1233 TypeError: Vnodes must either always have keys or never have keys!
  at Function.Vnode.normalizeChildren (mithril.js:21:11)
  at Function.Vnode.normalize (mithril.js:7:73)
  at Function.Vnode.normalizeChildren (mithril.js:25:25)
  at hyperscript (mithril.js:148:26)
  at m (mithril.js:1495:43)
  at SidebarSection.view (SidebarSection.ts:18:10)
  at Function.callHook (mithril.js:308:16)
  at initComponent (mithril.js:427:46)
  at createComponent (mithril.js:432:3)
  at createNode (mithril.js:343:8)

[vitoreiji]

@nowhub and I are testing Contacts.

[vitoreiji]

@nowhub and I are testing Appearance settings.

[vitoreiji]

@nowhub and I are testing Whitelabel settings.

[vaf-hub]

Found the following minor problem:

1. Signup as a Free account.
2. Go to subscription settings.
3. See that it reads "FREE". It should be "Free" without caps.

The same will happen always if the accountType is something other than Premium. It happens because of a change in TutanotaConstants.ts: export const AccountTypeNames = ["System", "Free", "Outlook", "Premium", "Stream", "External"] was replaced with export const AccountTypeNames = reverse(AccountType)

We should either keept the reversed map explicitly or convert the enum to natural capitalization for the definition of AccountTypeNames.

[vaf-hub]

I will test subscription settings.

[vitoreiji]

@nowhub and I are testing Contact form settings.

[vitoreiji]

@nowhub and I are testing Global settings.

[vaf-hub]

I am testing PaymentSettings

[vaf-hub]

I am testing GroupSettings

[vaf-hub]

I am testing UserSettings.

[vaf-hub]

I will continue with MailSettings now.

[mpfau]

I will focus on search now

[mpfau]

will start testing mail editing, now

[vitoreiji]

@vaf-hub can you test the rejected senders list? I cannot seem to make anything appear there, don't know what the correct conditions would be. Nvm found the server config.

[vitoreiji]

I'll test mail folders and drag & drop now.