tutao / tutanota

Tuta is an email service with a strong focus on security and privacy that lets you encrypt emails, contacts and calendar entries on all your devices.
https://tuta.com
GNU General Public License v3.0
6.06k stars 523 forks source link

Contact merge not offered unless one entry has no names #4186

Open kib42 opened 2 years ago

kib42 commented 2 years ago

Describe the bug When you have two or more contacts with the same email address the merge functions does not detect them unless one has empty first and last name fields

To Reproduce Steps to reproduce the behavior:

  1. Create contact "John Smith" and add email address
  2. Create contact "John" and add the same address for "John Smith"
  3. Click on "Merge" from the three dots menu
  4. Get message "No similar contacts found"

Expected behavior I expect to be offered to merge contacts with the same email address.

kib42 commented 2 years ago

The duplicate contacts are detected if one them has the same last name but no first name.

Jlll1 commented 2 years ago

The current logic is that contacts are not mergable if their lastnames are not equal and both contacts have at least one name field not empty. I'm not sure that having the contacts being marked as mergable just based on equal email address is correct, some people share an email address, but maybe adding a rule that contacts are mergable when: