tutao / tutanota

Tuta is an email service with a strong focus on security and privacy that lets you encrypt emails, contacts and calendar entries on all your devices.
https://tuta.com
GNU General Public License v3.0
6.06k stars 524 forks source link

AssertNotNull failed in drag handler #4198

Closed charlag closed 1 week ago

charlag commented 2 years ago

Cicked on notification about new mail, inbox opened, then error

Client: android
Tutanota version: 3.96.3
User agent:
[Android 12]

Error
Error message: AssertNotNull failed : null
Stacktrace:
Error: AssertNotNull failed : null
at p (file:///android_asset/tutanota/dist/common-min-bd0e3a79.js:1:11225)
at Qe.getVirtualElement (file:///android_asset/tutanota/dist/gui-base-1d58d190.js:1:179585)
at Qe.onHorizontalDrag (file:///android_asset/tutanota/dist/gui-base-1d58d190.js:1:177102)
at Qe.move (file:///android_asset/tutanota/dist/gui-base-1d58d190.js:1:156214)
at HTMLDivElement. (file:///android_asset/tutanota/dist/gui-base-1d58d190.js:1:155840)
charlag commented 1 year ago

I opened a hyperlink in Firefox on android 13, viewed some web pages, then hit the back button to return to the Tutanota app.

Client: android
Tutanota version: 3.110.1
User agent:
Mozilla/5.0 (Linux; Android 13; Pixel 6 Pro Build/TQ2A.230305.008.E1; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/111.0.5563.116 Mobile Safari/537.36
Error
Error message: AssertNotNull failed : null
Stacktrace:
Error: AssertNotNull failed : null
at l (https://assets.tutanota.com/common-min-3277242d.js:1:11518)
at Se.getVirtualElement (https://assets.tutanota.com/gui-base-06e3a291.js:1:161542)
at Se.onHorizontalDrag (https://assets.tutanota.com/gui-base-06e3a291.js:1:159059)
at Se.move (https://assets.tutanota.com/gui-base-06e3a291.js:1:139004)
at HTMLDivElement.<anonymous> (https://assets.tutanota.com/gui-base-06e3a291.js:1:138630)
charlag commented 3 weeks ago

Not sure how it happens but it would be very easy to fix: make getVirtualElement() return nullable value and check null in onHorizontalDrag()