Closed armhub closed 12 months ago
Looking into this I saw that the email address would be filled in consistently when using firefox, but not when using chrome. I tested this with a local build on versions 3.118.1, 3.117.0, 3.116.8, so I do not believe this is related to the latest release. In the LoginView the loginWith argument would always be filled in, even when it wasn't displayed. So the data is there, and something else is going wrong.
probably related commit 4f3bd9b41a8b87b3a32b91dd3571fea613de50a4
and therefore also https://github.com/tutao/tutanota/issues/4630
Reproducing and debugging this issue is not easy and it is not consistent. This could be a timing issue. It seems like this.loginForm.promise.then is not resolved in LoginView.handleLoginArguments() and therefore the email address is not set. We should observe it after releasing 3.118.1.
The issue is reproducible on the test system where there are saved accounts in the client. Here are some notes:
More notes for native Apps. Tested signups with both stored accounts and no stored accounts. All on version 3.118.5
example@
On production system:
The note with the saved accounts was very helpful! Since the loginForm is not recreated when switching from saved accounts to loginForm and signup, the loginForm promise is not resolved again and thus the url args are not read.
How to reproduce:
This bug exists since 3.118.1. Locally the bug could not be reproduced with 3.118.1. The URL is the same in both cases (/login?noAutoLogin=true&loginWith=". Additional observation: In the error case the "saved credentials" button is visible in the login form. In the other case it is not.
Test Notes: