tutao / tutanota

Tuta is an email service with a strong focus on security and privacy that lets you encrypt emails, contacts and calendar entries on all your devices.
https://tuta.com
GNU General Public License v3.0
5.86k stars 502 forks source link

Invalid build instructions #7081

Closed SkypLabs closed 3 weeks ago

SkypLabs commented 1 month ago

Bug in web app

Describe the bug

The build instructions present in doc/BUILDING.md are incomplete/invalid.

To Reproduce

When following the build instructions as they are today:

  1. git clone https://github.com/tutao/tutanota.git
  2. cd tutanota
  3. git checkout tutanota-release-230.240603.0
  4. npm ci
  5. npm run build-packages
  6. node webapp prod
  7. The build process fails as liboqs is missing.

Expected behaviour

The build process succeeds.

Additional context

I followed the build instructions on a Manjaro Linux system.

The build process failed because liboqs is imported as a Git submodule. However, the build instructions do not mention initialising the submodule. Moreover, once the Git submodules initialised, the build process was still failing as emcc was absent from my system.

I am preparing a PR to add/amend the faulty instructions.

SkypLabs commented 1 month ago

PR created: https://github.com/tutao/tutanota/pull/7083.

murilopereirame commented 3 weeks ago

Hey, thanks for your PR! But we already have one to be merged that accomplishes the changes. See #7066