tutorbookapp / tutorbook

Web app that helps schools and nonprofits connect students with expert mentors and volunteer tutors.
https://tutorbook.org
Other
59 stars 13 forks source link

wip: address ESLint errors #262

Open nicholaschiang opened 3 years ago

nicholaschiang commented 3 years ago

Fixes TB-139

linear[bot] commented 3 years ago

TB-139 Fix ESLint errors and enable Next.js build failing

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/tutorbook/tutorbook/3xsKQTUpa3hR23zjk4yUHyhq91zG
βœ… Preview: https://tutorbook-git-lint-tutorbook.vercel.app

nicholaschiang commented 3 years ago

πŸ“ Changed routes:

/[org]/users/[id]/edit /[org]/users/[id]/hours
Screenshot of /[org]/users/[id]/edit
(view full size)
Screenshot of /[org]/users/[id]/hours
(view full size)
/[org]/users/[id] /[org]/users/[id]/vet
Screenshot of /[org]/users/[id]
(view full size)
Screenshot of /[org]/users/[id]/vet
(view full size)
/[org]/users
Screenshot of /[org]/users
(view full size)

And 2 other routes:

Commit 0ed051025f69ba03cb151ab573aba6eebb441760 (https://tutorbook-j6ukp486d-tutorbook.vercel.app).

codecov[bot] commented 3 years ago

Codecov Report

Merging #262 (0ed0510) into develop (86cf428) will decrease coverage by 4.26%. The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #262      +/-   ##
===========================================
- Coverage    70.44%   66.17%   -4.27%     
===========================================
  Files          218      218              
  Lines         4568     4568              
  Branches      1244     1244              
===========================================
- Hits          3218     3023     -195     
- Misses        1350     1545     +195     
Impacted Files Coverage Ξ”
components/analytics/graph.tsx 0.00% <ΓΈ> (ΓΈ)
components/button/index.tsx 87.50% <ΓΈ> (ΓΈ)
components/calendar/meetings/item.tsx 0.00% <0.00%> (ΓΈ)
components/calendar/state.ts 33.33% <0.00%> (ΓΈ)
components/home/index.tsx 100.00% <ΓΈ> (ΓΈ)
components/login/index.tsx 97.72% <ΓΈ> (ΓΈ)
components/navigation/pop-over.tsx 67.64% <ΓΈ> (ΓΈ)
components/notification/index.tsx 100.00% <ΓΈ> (ΓΈ)
components/settings/context.ts 75.00% <0.00%> (ΓΈ)
components/settings/home.tsx 36.84% <ΓΈ> (ΓΈ)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 86cf428...0ed0510. Read the comment docs.

cypress[bot] commented 3 years ago



Test summary

28 5 0 0Flakiness 2


Run details

Project tutorbook
Status Failed
Commit 0ed051025f
Started Oct 25, 2021 10:20 PM
Ended Oct 25, 2021 10:37 PM
Duration 17:36 πŸ’‘
OS Linux Ubuntu - 20.04
Browser Chrome 94

View run in Cypress Dashboard ➑️


Failures

users/id/index.spec.ts Failed
1 User display page > collects profiles before booking meetings
2 User display page > lets parents book meetings for their kids
users/index.spec.ts Failed
1 Users page > falls back to invisible textarea copy-paste
2 Users page > copies org links and filters users
settings/index.spec.ts Failed
1 Org settings page > displays and updates org settings

Flakiness

cypress/tests/org/search.spec.ts Flakiness
1 Search page > partitions search results by org
2 Search page > filters users by subjects, langs, and name

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard