Fix termination category

PrenSJ2 commented 3 months ago

Close https://github.com/tutorcruncher/TutorCruncher2/issues/13663

Description

before posting to tc2 clients we modify the extra_attrs termination_category_value so that it replaces the space with -

we do this because TC2 expects dropdown values to be lowercase stripped and with a dash between words

Recreation steps:

follow new readme to setup pipedrive hermes and TC2
look at docs / live meta tc2 to see how the Termination Category custom field is setup
setup Termination category on meta
sign up company
check company is create in hermes and pd
mofiy meta client Termination category to one of drop down
API error in termination category formatting

Testing steps:

do above
termination category shouldn't cause any issues
once you have set the termination category the first time, you can just modify any other field like utm category in TC2 or Pipedrive and see that the webhook back to TC2 from hermes does not cause an error

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.78%. Comparing base (a42ad87) to head (f3a793b).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #235 +/- ## ========================================== + Coverage 93.77% 93.78% +0.01% ========================================== Files 29 29 Lines 1654 1657 +3 Branches 212 214 +2 ========================================== + Hits 1551 1554 +3 Misses 66 66 Partials 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PrenSJ2 commented 2 months ago

https://github.com/tutorcruncher/hermes/pull/240 should be merged first

tutorcruncher / hermes