search

tutorcruncher / hermes

1 stars 0 forks source link

handle json signup questionnaire #243

Closed PrenSJ2 closed 2 months ago

PrenSJ2 commented 2 months ago

Close #236

Technical Description

Take the tc2 client.meta_agency.signup_questionnaire json value from tc2, save it to the hermes Company then json dump it into a string for PD

also ignore changes to the signup_questionnaire in PD

Testing

PrenSJ2 commented 2 months ago
  • [ ] One scenario that the signup questionnaire doesn't go through is if the form isn't filled out before the company is created. If you wait for the company to be created and then fill out the form and submit, the hermes and pipedrive users don't have the data for the questionnaire until a new webhook is sent (eg. you edit the client). In the real thing tho I doubt people will be that slow filling it out and also I believe it takes longer to setup on live rather than locally.

like you have mentioned, this is unlikely to happen. only solution would be somehome force another client created or updated webhook to be sent to hermes from TC2 when the form is submitted

PrenSJ2 commented 2 months ago

Once this has been merged and deployed aerich upgrade will need to be run to perform the migration

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.56%. Comparing base (0ee58a7) to head (5fdfdbe).

Files Patch % Lines
app/base_schema.py 80.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## fix-bdr-sales #243 +/- ## ============================================== Coverage 93.56% 93.56% ============================================== Files 29 29 Lines 1740 1756 +16 Branches 237 242 +5 ============================================== + Hits 1628 1643 +15 Misses 71 71 - Partials 41 42 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.