Closed PrenSJ2 closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.56%. Comparing base (
3698535
) to head (cdb108c
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Estimated monthly income
seems to be getting set to None for some reason whenver its connected to hermes, maybe its cause its overriding old companies cause of the tc2 meta agency ids that didnt have estimated incomes, either way I'm not sure. See if you get the same and if you don't ignore this.
Otherwise the patch works and lgtm!
- [x] Not sure if I've got something setup wrong locally (I probably have), but seems whenever I sign up, my
Estimated monthly income
seems to be getting set to None for some reason whenver its connected to hermes, maybe its cause its overriding old companies cause of the tc2 meta agency ids that didnt have estimated incomes, either way I'm not sure. See if you get the same and if you don't ignore this.Otherwise the patch works and lgtm!
solved (was how dan has his hermes custom field setup)
Technical Description
Created a patch.py file
Created a patch to get all the companies without a bdr_person_id or sales_person_id, fetch their most up to date data in pd, to update the Company then send a webhook to TC2 to update the associated Cligencies
Testing
start/1
this will create the company in hermes and Org in PDbdr_person_id
field to the id of the bdr admin in hermes.testing@tutorcruncher.com
- doesn't send webhooksbdr_person_id
andbdr_person