tutorcruncher / hermes

1 stars 0 forks source link

Create patch.py + write patch to update TC2 Cligencies with sales and BDR person #254

Closed PrenSJ2 closed 2 months ago

PrenSJ2 commented 2 months ago

Technical Description

Created a patch.py file

Created a patch to get all the companies without a bdr_person_id or sales_person_id, fetch their most up to date data in pd, to update the Company then send a webhook to TC2 to update the associated Cligencies

Testing

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.56%. Comparing base (3698535) to head (cdb108c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #254 +/- ## ======================================= Coverage 93.56% 93.56% ======================================= Files 29 29 Lines 1756 1756 Branches 242 242 ======================================= Hits 1643 1643 Misses 71 71 Partials 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DanJezeph15 commented 2 months ago

Otherwise the patch works and lgtm!

PrenSJ2 commented 2 months ago
  • [x] Not sure if I've got something setup wrong locally (I probably have), but seems whenever I sign up, my Estimated monthly income seems to be getting set to None for some reason whenver its connected to hermes, maybe its cause its overriding old companies cause of the tc2 meta agency ids that didnt have estimated incomes, either way I'm not sure. See if you get the same and if you don't ignore this. image

Otherwise the patch works and lgtm!

solved (was how dan has his hermes custom field setup)