search

tutorcruncher / hermes

1 stars 0 forks source link

Issues TC2 webhook recreating orgs and people in PD after merge #264

Open gabegatrill opened 3 months ago

gabegatrill commented 3 months ago

Changes made on People and Organisations within Pipedrive become undone when changes are made on Meta as they won't match

We are unable to organise and merge duplicates or correct data within Pipedrive. Even when deleting organisations/people or merging, they will unmerge and create new records

PrenSJ2 commented 3 months ago

There are three main issues here.

  1. when orgs are merged in pd, pd appends the hermes id to the hermes id data field. This needs to be handled correctly on hermes to first get the correct hermes company. finding the one with the active tc2 id, and then updating the pd org to only have the correct hermes id

  2. Currently we don't allow hermes to update the tc2 cligency name (and maybe location), this means that any changes to the company name in PD will be reverted by the next tc2 webhook

  3. point that needs further discussion, if a company signs up to TC twice, one account is terminated and one is live. in theory there will be 2 Hermes Companies and 2 PD Orgs. what should happen / how should the merging of these two PD orgs be handled