tutorcruncher / hermes

1 stars 0 forks source link

Handle boolean realtionship between hermes and pd #286

Open PrenSJ2 opened 1 month ago

PrenSJ2 commented 1 month ago

Close #260

Technical Description

from Company to Organisation in get_custom_field_val; added logic to convert the boolean to a string

from Organisation to Company in company_dict in the cf_data_from_hermes we check if cf type is a bool and convert the string to a bool

updated get_custom_fieldinfo so that the annotation of the TYPE_BOOL custom fields is optional bool or str

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.07%. Comparing base (63afdab) to head (950b85b).

Files with missing lines Patch % Lines
app/pipedrive/_schema.py 71.42% 1 Missing and 1 partial :warning:
app/base_schema.py 83.33% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #286 +/- ## ========================================== - Coverage 90.07% 90.07% -0.01% ========================================== Files 29 29 Lines 1884 1894 +10 Branches 296 300 +4 ========================================== + Hits 1697 1706 +9 Misses 135 135 - Partials 52 53 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PrenSJ2 commented 1 month ago