search

tutors-sdk / tutors

The core Tutors Reader application.
https://tutors.dev
MIT License
109 stars 44 forks source link

View All Talks & Labs Auth Issue #498

Closed ddrohan closed 1 year ago

ddrohan commented 1 year ago

Hi Guys,

not sure if this is a bug or a 'feature' but even when there are topics hidden (via the properties file) and you need to enter the PIN to view all topics published, you can view all talks and labs from the menu options with no PIN?

Cheers, Dave

edeleastar commented 1 year ago

thanks dave - we would call that a bug certainly. Thanks

edeleastar commented 1 year ago

@ddrohan - I think this is fixed now

ddrohan commented 1 year ago

Hi Eamonn,

can you check this site?

https://tutors.dev/prog-fund-1-nuist-sept-2023.netlify.app

and the labs + talks wall?

Maybe it's down to my naming but it seems to be only hiding some of the talks and labs not all of them?

I'll add you to the repo on bitbucket if you want to have a closer look?

Cheers, Dave.

edeleastar commented 1 year ago

Hi @ddrohan ,

you are correct - my initial attempt was flawed.

New version pushed now - can you check again?

Eamonn

ddrohan commented 1 year ago

That's great Eamonn, all seems to be working now thanks!

A somewhat related question - can you think of any reason why, on campus, some students on hotspots, some on the wifi, would get a 404 error on the site, and be taken to the tutors.dev home page?

Honestly Eamonn, without Tutors, I don't think I could be delivering the module the best way possible over here, as the students are not registered on Moodle yet, so it would be like a trip back to the 90's using handouts or trying to email pdfs to the class.

Networking wouldn't be my strong suit, so I'm not able to work out why some students can access the material with no issues and others get a 404? I have shared an offline version (which is another lifesaver!) but that could be time consuming, every week, generating a new version and trying to make sure everyone can access it correctly via slack (DL speeds on campus aren't great!)

So I guess I'm asking, have you come across this back home, and/or any suggestions on how to get to the bottom of it?

Thanks again for closing this issue Eamonn :) Dave.