tuttle-dev / tuttle

🪰 Tuttle - time and money management for freelancers
GNU General Public License v3.0
63 stars 12 forks source link

UI Bug: Payment settings invisible after error on Invoicing screen #193

Closed clstaudt closed 1 year ago

clstaudt commented 1 year ago

The Payment settings form can disappear from the Preferences screen.

Steps to reproduce:

  1. Check that payment settings form is there

Image

  1. Navigate to "Invoicing" screen, receive error message in snack bar

Image

  1. Check that payment settings form is gone

Image

clstaudt commented 1 year ago

This looks like an example of the "action at a distance" anti-pattern and may indicate a software architecture problem.

vlad-ed-git commented 1 year ago

Ok. Will check.

vlad-ed-git commented 1 year ago

fixed on dev-db-refactor branch. Pending review and merge to dev.

clstaudt commented 1 year ago

Thanks @vlad-ed-git . Was this a minor bug or an architecture problem?

(I'd recommend the following branching policy: One ticket, one branch, one PR.)

clstaudt commented 1 year ago

@vlad-ed-git Could you do the merge please, dev-db-refactor currently conflicts with dev.

vlad-ed-git commented 1 year ago

@clstaudt It was a minor bug. I will perform the merge.

vlad-ed-git commented 1 year ago

@clstaudt I have completed the merge.

clstaudt commented 1 year ago

It's working now ✅