search

tuttle-dev / tuttle

🪰 Tuttle - time and money management for freelancers
GNU General Public License v3.0
63 stars 12 forks source link

Dev UI cls #92

Closed clstaudt closed 1 year ago

clstaudt commented 1 year ago

@vlad-ed-git Some adjustments and additions - please merge if there is no major mistake here

clstaudt commented 1 year ago

@vlad-ed-git FYI, I made a few layout changes

clstaudt commented 1 year ago

@vlad-ed-git We are diverging here and it's getting hard to merge. What happens if you try to merge this into dev-ui-vlad?

clstaudt commented 1 year ago

@vlad-ed-git Before you continue editing the code please merge this so that we don't diverge too much

clstaudt commented 1 year ago

@vlad-ed-git This is getting really hard to merge now. You are planning to delete files to which I have added features.

Screenshot 2022-12-12 at 10 45 19
clstaudt commented 1 year ago

@clstaudt The primary color is used by the system to create shades highlighting different content. If we set gray color as the primary color, some shades of gray are not readable over white/dark backgrounds (which is the main background when appearance is set to light or dark).

I don't fully understand yet how the primary color is used to define the theme. It seemed to work fine with gray. I just wanted to get rid of this very blue (ca. (0,0,255)) for aesthetic reasons. What would you suggest?

vlad-ed-git commented 1 year ago

Set the primary color to gray then check for example, when you select "completed" on the projects. That button will be in the selected state, which has a primary color. Inactive states are set to gray, if you make gray primary, then there is no visual difference between inactive/disabled elements with activated/focused ones. Also, the gray you set is a very light shade of gray, which is not readable on some elements because of their background. You can check out Material Design Colors https://m2.material.io/design/color/the-color-system.html#tools-for-picking-colors and try other hex values from here. But gray, white, black, and error colors are already defined in the colors file and used in other sections, so the primary color cannot be any of these values (unless we change the others as well).

On Mon, Dec 12, 2022 at 11:29 PM Christian Staudt @.***> wrote:

@clstaudt https://github.com/clstaudt The primary color is used by the system to create shades highlighting different content. If we set gray color as the primary color, some shades of gray are not readable over white/dark backgrounds (which is the main background when appearance is set to light or dark).

I don't fully understand yet how the primary color is used to define the theme. It seemed to work fine with gray. I just wanted to get rid of this very blue (ca. (0,0,255)) for aesthetic reasons. What would you suggest?

— Reply to this email directly, view it on GitHub https://github.com/tuttle-dev/tuttle/pull/92#issuecomment-1346703953, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJGBW64PDJYYIYSWGTE7ZN3WM5AE5ANCNFSM6AAAAAASO3ZS5Q . You are receiving this because you modified the open/close state.Message ID: @.***>