search

tuttleofx / TuttleOFX

Tuttle OFX is a library to connect and batch operations with OpenFx plugins. It comes with a set of plugins that allows you to batch process on movies and file sequences.
www.TuttleOFX.org
Other
179 stars 64 forks source link

Histogram Keyer Node Bug #353

Open blackearth2014 opened 10 years ago

blackearth2014 commented 10 years ago

Hello Fabien

I had downloaded the new tuttle binaries for the mac. The attached images is a result of that new download. I don't even have the Histogram Keyer Node attached and it has taking focus of the Natron's viewer output.

Best regards, Omar

tuttle_histogramkeyer

fabiencastan commented 10 years ago

See https://github.com/MrKepzie/Natron/issues/223

devernay commented 10 years ago

Found one bug in TuttleHistogramKeyer. The function HistogramKeyerOverlay::displaySelectedAreas() does not enable blending. By chance, Nuke enables it, but other hosts (e.g. Natron) do not. The function should start with:

glEnable(GL_BLEND);
glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
glTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE);

and end with:

glDisable(GL_BLEND);
devernay commented 10 years ago

Another bug: TuttleHistogramKeyer should call Interact::addParamToSlaveTo(Param* p) for all params that affect the overlay display (i.e. most of the parameters...)

devernay commented 10 years ago

Another bug: TuttleHistogramKeyer claims it supports OFX::ePixelComponentRGB, but the red, green, blue histograms are wrong. They are probably computed by considering the image data as RGBA, which results is almost equal red, green and blue curves (colors are mixed). Nuke doesn't support RGB, but this can be tested easily using Natron.

devernay commented 10 years ago

TuttleHistogramKeyer also calls OfxParametricInstance::addControlPoint with NaN values (this used to crash Natron, but we are now robust against this)