search

tuupola / branca-spec

Authenticated and encrypted API tokens using modern crypto
https://www.branca.io/
219 stars 7 forks source link

Base62 is actually Base61 #22

Closed johnaoss closed 4 years ago

johnaoss commented 4 years ago

The character set provided in the spec: 

0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxy

Only contains 61 characters, and is thus a base61 encoding. Looking at the implementations listed on the document, it seems that most of them (if not all) include a z to the character set as I would expect.

Is this the intended behaviour? Or should the character set not include the character z?

tuupola commented 4 years ago

You are correct. Seems to be copy paste error. The z is missing. It should be 0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz.

tuupola commented 4 years ago

Thanks for the heads up!