Zend Expressive Don't work CORS

[lpj145]

On last version of zend expressive https://docs.zendframework.com/zend-expressive/

The cors not works right!

When i:

i think it not pass to cors on next function.

[tuupola]

The above code does not seem to be from my cors middleware?

[lpj145]

above is a simple cors middleware, i can't implement you middleware.

[lpj145]

please see it: https://gist.github.com/lpj145/cd2d8760ee08fb5ab9db4e05ed68b329#file-tuupolacors-php-L53

[tuupola]

Ah yes now I understand. There is no PSR-15 support yet because PSR-15 is not finalized. However Expressive has a PSR-15 wrapper for PSR-7 style middlewares.

[lpj145]

oh, its song good for me, i need make factory to do it ?

[Xerkus]

Zend Expressive 2 wraps automatically, actually it is Zend Stratigility that does the wrapping, so it just works, nothing else needs to be done. https://github.com/zendframework/zend-stratigility/blob/master/src/MiddlewarePipe.php#L135 and https://github.com/zendframework/zend-stratigility/blob/master/src/MiddlewarePipe.php#L224

[tuupola]

@Xerkus that is what I thought.

@lpj145 Can you show example code how you initialise the middleware and an example curl request which fails. For example:

$ curl "https://api.example.com/foo" \
    --request OPTIONS \
    --include \
    --header "Origin: http://www.example.com" \
    --header "Access-Control-Request-Method: PUT" \
    --header "Access-Control-Request-Headers: Authorization, If-Match"

[lpj145]

[lpj145]

[tuupola]

Copy pasting code is preferred over screenshots. When testing copy paste my curl command exactly except the url. For example you should use --header "Origin: http://www.example.com" not --header "Origin: http//:www.example.com"

[lpj145]

curl lvh.me/ -v --request OPTIONS --include --header "Origin: http://www.example.com" --header "Access-Control-Request-Method: PUT"

[tuupola]

You can use three ` characters to format the code.

https://guides.github.com/features/mastering-markdown/

[lpj145]

curl lvh.me/ -v --request OPTIONS --include --header "Origin: ht" --header "Access-Control-Request-Method: PUT"

[lpj145]

I'm very grateful for that.

[tuupola]

I just tested with the latest Expressive and everything seems to be working as exptected. Code copied from examples.

<?php

use Interop\Http\ServerMiddleware\DelegateInterface;
use Zend\Diactoros\Response\TextResponse;
use Zend\Expressive\AppFactory;

chdir(dirname(__DIR__));
require "vendor/autoload.php";

$app = AppFactory::create();

$app->get("/", function ($request, DelegateInterface $delegate) {
    return new TextResponse("Hello, world!");
});

$app->pipe(new Tuupola\Middleware\Cors([
    "origin" => ["*"],
    "methods" => ["GET", "POST", "PUT", "PATCH", "DELETE"],
    "headers.allow" => [],
    "headers.expose" => [],
    "credentials" => false,
    "cache" => 0,
]));

$app->pipeRoutingMiddleware();
$app->pipeDispatchMiddleware();
$app->run();

$ curl http://localhost:8081 --include --header "Origin: http://example.com"
HTTP/1.1 200 OK
Host: localhost:8081
Date: Wed, 20 Sep 2017 13:09:03 +0000
Connection: close
X-Powered-By: PHP/7.1.6
Content-Type: text/plain; charset=utf-8
Access-Control-Allow-Origin: http://example.com
Vary: Origin

Hello, world!