Update phpstan to the most recent version

tuupola / cors-middleware

PSR-7 and PSR-15 CORS middleware

MIT License

132 stars 16 forks source link

Update phpstan to the most recent version #63

Closed usox closed 2 years ago

usox commented 2 years ago

This updates phpstan and introduces a bunch of new type hints and type corrections. Also add phpstan-strict-rules to be even more strict.

Bump minimal required php version to 7.2
Update/correct/add some type hints in the tests

usox commented 2 years ago

Ah, it's 7.1 again - sigh. Well I guess, downgrading stan to 1.4 wouldn't be much of a problem.

tuupola commented 2 years ago

Oh wait. Actually I think we can do an exception and allow PHP 7.1 to fail, or alternatively bump up the minimum requirements 7.1 has been EOL for a while...

usox commented 2 years ago

Oh wait. Actually I think we can do an exception and allow PHP 7.1 to fail, or alternatively bump up the minimum requirements 7.1 has been EOL for a while...

I already prepared a follow up PR which bumps neomerx/cors-psr7 to v2. I'd be happy to also upgrade the minimum php version requirement to...well...what? 7.4 (which is also EOL)...so maybe 8?

tuupola commented 2 years ago

Only PHP 7.1 failed so only it should be removed.

usox commented 2 years ago

Here we go.

tuupola commented 2 years ago

Thanks!