Closed smarq8 closed 1 year ago
These should be two different PRs. Only one feature or fix per PR.
I didnt test this library because I use higly modimied fork of this library, and also I do not know much abot PR yet.
Best way to do a PR is to make a new branch from master of your own fork. Edit the files and commit them. When ready open a PR against my repository
$ git clone https://github.com/smarq8/hagl.git smarq8_hagl
$ cd smarq8_hagl
$ git checkout -b fix-filled-circle
<edit files>
$ git commit .
$ git push
<create a PR in github>
Do you have the modified version available somewhere? It would be interesting to see.
I improved draw ricle, now it use hline and vline when possible insted of put_pixel. It seems more complex but it reduce wasting time for display communication to minimum. As shown in benchmark below its 2x faster. I also fix fill circle so they both should produce exactly same circles. I didnt test this library because I use higly modimied fork of this library, and also I do not know much abot PR yet. If something is wrotn then sorry.
my benchmark code for draw circle: