Found a dot that is not rendered at bottom right of screen.

tuupola / hagl

Hardware Agnostic Graphics Library for embedded

https://www.appelsiini.net/tags/hagl/

MIT License

296 stars 47 forks source link

Found a dot that is not rendered at bottom right of screen. #53

Open BobDNA opened 2 years ago

BobDNA commented 2 years ago

Is that dot is by design or bug? I used : ESP-IDF 4.3.1 TTGO T-DISPLAY

I found this dot in your example too (esp_gfx and esp_effect).

tuupola commented 2 years ago

Sounds like an off by one bug somewhere. Will check.

BobDNA commented 2 years ago

OK, I think I found this bug. It is not a bug in hagl library. It is a bug related to hagl_hal_clear_screen() function in hagl_esp_mipi library which is used in hagl_hal_triple.c and hagl_hal_double.c.

The line 172 in hagl_hal_triple.c and line 187 in hagl_hal_double.c

Both lines may need to be changed from size_t count = DISPLAY_WIDTH DISPLAY_HEIGHT; --> size_t count = DISPLAY_WIDTH DISPLAY_HEIGHT +1;

Not sure is this correct?