tuupola / micropython-mpu9250

MicroPython I2C driver for MPU9250 9-axis motion tracking device
MIT License
141 stars 47 forks source link

Fix gyro degrees to radians conversion #8

Closed will121173 closed 5 years ago

will121173 commented 5 years ago

I think line123 means deg to rad. old : deg (180/pi) -> too big new: deg (pi/180) -> rad to fit to the "accel" sentences, I changed variable.

I am not used to pull request. Please forgive me. Even if it is strange.

tuupola commented 5 years ago

You seem to be correct. Other option would be to change this:

return tuple([value / so * sf for value in xyz])

to

return tuple([value / so / sf for value in xyz])

But yours is the technically correct way to do it. Will merge soonish. Thanks!

tuupola commented 5 years ago

Released as 0.2.1. Thanks!

https://pypi.org/project/micropython-mpu9250/