Closed FluffyHyena closed 4 years ago
Thanks a lot! 🙂
On first glance it all looks fine, I'll test it as soon as possible and send you some screenshots to review, once everything looks good I'll merge this.
I've run the app everything seems to work fine, but it seems like you (and I) forgot to add a few things:
pref_list_language_titles
lists (x3) have a "Spanish" value (not manually selectable otherwise), keep in mind that the order should be the same everywhere (same as pref_list_language_values
in arrays.xml). You can use "Spaans" as a Dutch/NL translation.This is some test output for you to check:
00:00 -> docey cinco
00:01 -> docey cinco
01:03 -> unay cinco
02:05 -> dosy cinco
03:07 -> tresy diez
04:10 -> cuatroy diez
05:14 -> cincoy cuarto
06:15 -> seisy cuarto
07:16 -> sietey veinte
08:20 -> ochoy veinte
09:29 -> nuevey media
09:30 -> nuevey media
09:31 -> nuevemenos veinticinco
09:35 -> diezmenos veinticinco
09:36 -> diezmenos veinte
10:41 -> oncemenos cuarto
11:50 -> docemenos diez
12:53 -> unamenos cinco
12:55 -> unamenos cinco
13:57 -> dos
14:59 -> tres
15:00 -> tresy cinco
23:50 -> docemenos diez
And some screenshots:
Time was 22:15:
Thanks again!
Ok! In this order:
Woops! Fixed! It should be alright now, thank you!
Visible is the same in both languages! It was like "time to edit this! Oh wait, it doesn't need to be edited"
Sure thing! Fortunately we use the same names for fonts than English, but the names for the emphasis are, in this order: Normal, Negrita, Cursiva, Negrita Cursiva. Hope that helps!
Also I just fixed an error in the display where I forgot to move the space string between the hour and minute string and I went and made the minutes more like the base English code rather than adding/removing anything sooo it should be ok now! Let me know of anything else!
Added a Spanish translation both to the widgets and the menu, but can't test if it works as I don't have the means to compile the app. I hope it's ok!