search

tuura / plato

A DSL for asynchronous circuits specification
Other
12 stars 2 forks source link

Reset stack file to use lts-7.5 for GHC 8.0.1 #57

Closed jrbeaumont closed 7 years ago

jrbeaumont commented 7 years ago

This change is so stack uses GHC 8.0.1 and dependencies, particularly hint-0.6.0 as earlier versions have issues with GHC later than 7.10.3.

@snowleopard Please hold off on merging until I have changed the manual, README and Workcraft error messages to inform users to setup stack with the flag --no-system-ghc, and to point to the general install information for stack from https://docs.haskellstack.org/en/stable/install_and_upgrade/

I cannot decide, so which would you prefer:

Ask users to check their system GHC version for >=8.0.1 and if it is, use just stack setup and stack build, otherwise use stack setup --no-system-ghc and stack build --no-system-ghc

Or

Ask all users to use stack setup --no-system-ghc and stack build --no-system-ghc regardless of their GHC version.

(With stack build I don't think --no-system-ghc changes anything, providing this flag is used for stack setup)

snowleopard commented 7 years ago

@jrbeaumont Let's go for stack setup --no-system-ghc and stack build unconditionally for simplicity.

jrbeaumont commented 7 years ago

@snowleopard: That should be all instructions updated :)

jrbeaumont commented 7 years ago

@snowleopard This should be fixed :)

snowleopard commented 7 years ago

Thanks @jrbeaumont! Shall I merge this now?

jrbeaumont commented 7 years ago

@snowleopard Yes please, Travis is being slow on macOS again.

jrbeaumont commented 7 years ago

@snowleopard: Wait no.

snowleopard commented 7 years ago

Oops, merged!

jrbeaumont commented 7 years ago

No problem, I'll send another PR.

jrbeaumont commented 7 years ago

My fault, sorry!

snowleopard commented 7 years ago

I've reverted the commit, so do send another PR

jrbeaumont commented 7 years ago

OK, thanks. Sorry!