search

tuura / plato

A DSL for asynchronous circuits specification
Other
12 stars 2 forks source link

Added options for including external concept files #63

Closed jrbeaumont closed 7 years ago

snowleopard commented 7 years ago

Nice. Thanks @jrbeaumont!

You can probably merge this yourself now? If yes, feel free to go ahead :)

jrbeaumont commented 7 years ago

I can merge myself but I'll make some small changes and sort it out :)

Adrian has completed the FSM translation so I'm gonna merge it and test and do another PR for that, which would be nice to have some of your input for that.

I'm thinking we should have separate FSM and STG libraries, as at some point they may diverge, with things like the unstable signal implementation, or anything else which may not be transferable for FSMs and STGs and it may be better to have separate concept libraries for these from the beginning, instead of combining these, and then separating them again later. What do you think?

snowleopard commented 7 years ago

OK, makes sense. Let's keep FSM and STG libraries separate for now. But can you do that without duplicating some big chunks of code, like the Cartesian product stuff?

Happy to do code review!

jrbeaumont commented 7 years ago

I am not sure how much I can avoid duplicating. I will have a play around and see what's is possible.