search

tuura / plato

A DSL for asynchronous circuits specification
Other
12 stars 2 forks source link

Refactored repeated circuit/abstract code into single files #66

Closed jrbeaumont closed 7 years ago

jrbeaumont commented 7 years ago

@snowleopard: I have fixed the repeated code issues.

I had to create Tuura.Concept.Circuit... as I tried replacing the existing Tuura.Concept.Circuit and Tuura.Concept.Abstract but this causes issues with the simulation testing.

What do you think now?

snowleopard commented 7 years ago

Looks good!

To avoid awkward Circuit.Circuit, perhaps, we could have Circuit.Basic (instead of Circuit.Abstract) and Circuit.Derived (instead of Circuit.Circuit)?

jrbeaumont commented 7 years ago

@snowleopard I have renamed those. They are better names. Thank you

snowleopard commented 7 years ago

Thanks! I have a feeling that we will still need to make some renaming to finally get it right, but for now let's go with this.

Shall I merge?

jrbeaumont commented 7 years ago

Not yet, there's issues with the testing that I have just fixed. Let's just confirm that the CI passes :)

I agree, some names need to be changed, but we can work this out while the tool works.

jrbeaumont commented 7 years ago

@snowleopard Can we merge this now?

snowleopard commented 7 years ago

@jrbeaumont Done!