Closed jrbeaumont closed 7 years ago
Thanks @jrbeaumont! See a bunch of comments above :)
@snowleopard:
I have made these changes, including NonEmpty
, excluding InvariantViolated (Invariant a)
, as we discussed.
I have also moved some things around while I've been at it for use with Workcraft, as I have been working on updating Workcraft for use with the new features concurrently. The major thing that will be coming up is changing errors to be output to STDERR, and everything else to STDOUT.
Have a look in your own time and let me know if you'd like any more changes made :)
@snowleopard: I have fixed those now :)
@jrbeaumont Thanks! One last touch (I'm surprised you didn't get a warning for redundant case).
@snowleopard: I did get an error, I just missed it and was working on something else, my bad haha.
Right. So, shall I merge this now?
I would wait until the CI checks pass. I have tested it on my mac, but it would be nice to be sure it definitely passes on everything.
So far, added
AndCausality
andOrCausality
toCausality
data type, which starts off #69, but we will need more discussion to include things likeTimingAssumption
.Validation and translation are reordered for FSMs (#68). The initial states are checked first, and if valid, the translation is done. Following this, a check for signals with no interface declared, as well as for reachable
never
states. If this is valid, then the translation completes, outputting the.sg
file. Otherwise, it outputs a handy error message, explaining either the problematic signal, or thenever
that is violated.