Closed ARandomOWL closed 6 years ago
@ARandomOWL Thanks! I've left a bunch of comments above.
I have addressed most comments. I will look into dealing with the parsing errors, I'm not too clear on it at the moment.
@snowleopard Parse errors are now handled
@snowleopard I have changed over to the PrettyPrint library. I'm still not happy with the code. Problems stem from the pPrint String
instance being implemented as text . show
. I would be grateful of suggestions for improvement.
@ARandomOWL What about defining only the Pretty (Literal String)
instance? If you drop the more general Pretty a => Pretty (Literal a)
there will be no overlapping. Users can then define Pretty
instances for literals of their favourite types themselves. Same for DNF
/CNF
.
@snowleopard I agree it makes sense to remove the generic instances for now. I have pushed that but Appveyor seems to be having problems unrelated to my code.
OK, looks good -- just one minor comment.
I've addressed the comment, and now the checks pass :)
👍
The show instances are useful when manipulating boolean equations directly.