search

tuura / plato

A DSL for asynchronous circuits specification
Other
12 stars 2 forks source link

Added comprehensive comments to compilation/translation modules #95

Closed jrbeaumont closed 6 years ago

jrbeaumont commented 6 years ago

@snowleopard Here are my comments on the modules involved in compilation and translation of concepts. Do you have time to have a read of them?

jrbeaumont commented 6 years ago

Shall I update the copyright by the way, in the license? Is there a particular method of doing it, or can I just update to switch to "2015-2018"?

snowleopard commented 6 years ago

Thanks, I like it, quite detailed! I've left a few comments.

Be consistent with the ending dot . -- not all comments are ended with it.

jrbeaumont commented 6 years ago

Thanks, I'll make those changes. Did you see the above comment?

snowleopard commented 6 years ago

Shall I update the copyright by the way, in the license? Is there a particular method of doing it, or can I just update to switch to "2015-2018"?

Yes, just go ahead and switch it to 2015-2018 by hand everywhere. Do this in a separate commit.

jrbeaumont commented 6 years ago

by hand everywhere

It's just in the license is it not? I cannot find any other copyright information anywhere.

snowleopard commented 6 years ago

It's just in the license is it not?

Yep, perhaps only there.

jrbeaumont commented 6 years ago

@snowleopard Those fixes have been done, and the copyright updated.

snowleopard commented 6 years ago

Great, thank you! Go ahead and merge when you're done.