search

tuuzdu / crab_project

ROS hexapod robot on BeagleBone Black
97 stars 40 forks source link

What reason for nested package? #2

Open manuelmiermetz opened 6 years ago

manuelmiermetz commented 6 years ago

Hi tuucdu, impressive work! I wonder why there is a BBB directory containing a copy of all the modules. At least it looks like this. After removing BBB and fixing some dependency issues it builds now in kinetic.

tuuzdu commented 6 years ago

Hi! BBB folder just contains modules necessary on board BeagleBone for keep it in mind) What are dependency issues?

manuelmiermetz commented 6 years ago

okay so this BBB directory is not intended to belong to the crab_project ros module and can be removed (otherwise catkin tries to build redundant submodules and fails) Thank's for making this clear

dependency issues have been found in all CMakeList and project.xml files. Only minor stuff. e.g. following lines had to be updated

find_package(catkin REQUIRED COMPONENTS
  orocos_kdl
  kdl_parser
  roscpp
  crab_msgs
)

to 

find_package(catkin REQUIRED COMPONENTS
  kdl_parser
  roscpp
  crab_msgs
)

find_package(orocos_kdl)

and dependency crab_msgs is missing in most sub modules which leads to a mess during catkin build. There are several forks of crab_project addressing these issue. See my fork and the first two commits. If you like I can prepare a pull request

tuuzdu commented 6 years ago

Thank you for information! I will reformed structure of folder.

It will be great if you prepare a pull request.