search

tuvokki / pleague

A league system for the company fußball
0 stars 3 forks source link

Be able to revert a wrongly appointed goal #34

Open elgervb opened 8 years ago

elgervb commented 8 years ago

I'm working on it ;-)

tuvokki commented 8 years ago

While you're at it @elgervb can you fix this also? image

mabertcloud commented 8 years ago

I think the easiest fix is to delete the player "AnnieAnnieAnnieAnnieAnnie"

tuvokki commented 8 years ago

Max player name is already limited to 26 chars due to my poor css skills 😜

Maybe we should add an ELO-penalty per letter ....

tuvokki commented 8 years ago

This functionality does not work as advertised, it seems that the only player you can revert a goal from is the top-right most player (in the above screenshot 'Annie...')

Also, when I revert a goal from Annie when she has no goals left it will be extracted from the blue team.

@elgervb can you take care of this and update the pull-request? Also please remove the (rather profane) todo's from your commit, since they have no bearing on this case, you can create a new issue to refactor the logic.

elgervb commented 8 years ago

Correct. I have a fix ready. Shall check iT in somewhere thuis weekend

tuvokki commented 8 years ago

That's good hoor :bowtie:

tuvokki commented 8 years ago

It does not seem to work on mobile. I tested it on an iPhone and the long-press did not change the buttons to wiggly-waggle and invert.

tuvokki commented 8 years ago

Ps. please refrain from todo's in parts of the code that do not involve this functionality

tuvokki commented 8 years ago

@elgervb it would be great if you can you take another look at this, there are two topics to look into: 1. when reverting a goal from the red team, the blue defender also gets one goal reverted

  1. it does not work on mobile
  2. has been fixed in 30397c67c10a8e981f3e592396c4e379f1245673